More adjustments

There still needs to be clarity about GetIssueDependencies Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath · Mar 20, 2023 · 1b1e755 · 1b1e755
1 parent 96831f4
commit 1b1e755
Show file tree

Hide file tree

Showing 3 changed files with 171 additions and 122 deletions.
diff --git a/models/issues/dependency.go b/models/issues/dependency.go
@@ -134,7 +134,7 @@ func CreateIssueDependency(user *user_model.User, issue, dep *Issue) error {
 	}
 	defer committer.Close()
 
-	// Check if it aleready exists
+	// Check if it already exists
 	exists, err := issueDepExists(ctx, issue.ID, dep.ID)
 	if err != nil {
 		return err

diff --git a/routers/api/v1/api.go b/routers/api/v1/api.go
@@ -1027,8 +1027,8 @@ func Routes(ctx gocontext.Context) *web.Route {
 						}, mustEnableAttachments)
 						m.Combo("/dependencies").
 							Get(repo.GetIssueDependencies).
-							Post(reqToken(auth_model.AccessTokenScopeRepo), bind(api.IssueMeta{}), repo.CreateIssueDependency).
-							Delete(reqToken(auth_model.AccessTokenScopeRepo), bind(api.IssueMeta{}), repo.RemoveIssueDependency)
+							Post(reqToken(auth_model.AccessTokenScopeRepo), mustNotBeArchived, bind(api.IssueMeta{}), repo.CreateIssueDependency).
+							Delete(reqToken(auth_model.AccessTokenScopeRepo), mustNotBeArchived, bind(api.IssueMeta{}), repo.RemoveIssueDependency)
 						m.Combo("/blocks").
 							Get(repo.GetIssueBlocks).
 							Post(reqToken(auth_model.AccessTokenScopeRepo), bind(api.IssueMeta{}), repo.CreateIssueBlocking).