Issue 5924 fix compare button (go-gitea#5929)

* Revert go-gitea#5877 This unfortunately was not the solution. Signed-off-by: Andrew Thornton <art27@cantab.net> * Change permission check to create pull requests to CanReadIssuesOrPulls Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath · Feb 16, 2019 · df00089 · df00089
1 parent 3b612ce
commit df00089
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/routers/api/v1/repo/pull.go b/routers/api/v1/repo/pull.go
@@ -668,8 +668,8 @@ func parseCompareInfo(ctx *context.APIContext, form api.CreatePullRequestOption)
  ctx.ServerError("GetUserRepoPermission", err)
  return nil, nil, nil, nil, "", ""
  }
- if !perm.CanWrite(models.UnitTypeCode) {
- log.Trace("ParseCompareInfo[%d]: does not have write access or site admin", baseRepo.ID)
+ if !perm.CanReadIssuesOrPulls(true) {
+ log.Trace("ParseCompareInfo[%d]: cannot create/read pull requests", baseRepo.ID)
  ctx.Status(404)
  return nil, nil, nil, nil, "", ""
  }

diff --git a/routers/repo/pull.go b/routers/repo/pull.go
@@ -684,8 +684,8 @@ func ParseCompareInfo(ctx *context.Context) (*models.User, *models.Repository, *
  ctx.ServerError("GetUserRepoPermission", err)
  return nil, nil, nil, nil, "", ""
  }
- if !perm.CanWrite(models.UnitTypeCode) {
- log.Trace("ParseCompareInfo[%d]: does not have write access or site admin", baseRepo.ID)
+ if !perm.CanReadIssuesOrPulls(true) {
+ log.Trace("ParseCompareInfo[%d]: cannot create/read pull requests", baseRepo.ID)
  ctx.NotFound("ParseCompareInfo", nil)
  return nil, nil, nil, nil, "", ""
  }

diff --git a/templates/repo/home.tmpl b/templates/repo/home.tmpl
@@ -54,7 +54,7 @@
  <div class="ui stackable secondary menu mobile--margin-between-items mobile--no-negative-margins">
  {{if and .PullRequestCtx.Allowed .IsViewBranch}}
  <div class="fitted item">
- <a href="{{.BaseRepo.Link}}/compare/{{.BaseRepo.DefaultBranch | EscapePound}}...{{ if .Repository.IsFork }}{{.Repository.Owner.Name}}{{ else }}{{ .SignedUserName }}{{ end }}:{{.BranchName | EscapePound}}">
+ <a href="{{.BaseRepo.Link}}/compare/{{.BaseRepo.DefaultBranch | EscapePound}}...{{if ne .Repository.Owner.Name .BaseRepo.Owner.Name}}{{.Repository.Owner.Name}}:{{end}}{{.BranchName | EscapePound}}">
  <button class="ui green tiny compact button"><i class="octicon octicon-git-compare"></i></button>
  </a>
  </div>