UserAPI.userCreateToken doesn't return token

[slonopotamus]

According to Swagger schema, userCreateToken returns AccessToken: https://github.com/zeripath/java-gitea-api/blob/master/swagger.v1.json#L11452-L11495

But in generated bindings, userCreateToken method is void: https://github.com/zeripath/java-gitea-api/blob/master/src/main/java/io/gitea/api/UserApi.java#L632

[zeripath]

Ugh. I'll take a look. I knew that there was something manual I had to do to the swagger JSON.

[zeripath]

I've uploaded a fixed release 1.14.0 right now - this should work on all 1.14.x versions of Gitea.

I'll pop a PR on to Gitea to fix this more permanently.

[zeripath]

We need this patch currently: dcfe46c#diff-7737fa973a12da8a4c6a99b8ab264b33fcad87756116a3ba93d16292d8878651

[zeripath]

@slonopotamus do you need me to release a fixed 1.13.x?

[slonopotamus]

Yes, please, I can't upgrade due to this bug.

[slonopotamus]

Err... If you released 1.14, then it's fine, no need for additional release.

[zeripath]

Cool. OK 1.14.0 has been released.

[slonopotamus]

I somewhat forgot about this thing and now tried to upgrade to newer java-gitea-api again.

The problem is: yes, userCreateToken now returns an AccessToken object. But. AccessToken only has name field: https://github.com/zeripath/java-gitea-api/blob/master/src/main/java/io/gitea/model/AccessToken.java#L32-L33 It doesn't have token itself. So while I can create tokens, I have no idea what token was created and thus can't pass it to API.

P.S. Also note that with modern Swagger schema (1.16.0+dev-56-gb9a0e3323 from https://try.gitea.io/swagger.v1.json) userCreateToken again generates with void return type.

[slonopotamus]

Note that back in older days, userCreateToken has a working signature: AccessToken userCreateToken(String username, AccessTokenName accessTokenName). It accepted just token name and returned a full object that had sha1 among other fields.

[zeripath]

ugh sorry about this!

[zeripath]

Probably need to reapply a99fa0c each time.

[slonopotamus]

Maybe we should report it upstream (Gitea)? I'm not an expert in Swagger, so don't actually understand why it can't properly generate userCreateToken signature.