Skip to content
This repository has been archived by the owner on Jul 5, 2019. It is now read-only.

Add type support to form validation #13

Merged
merged 4 commits into from
Dec 14, 2017
Merged

Add type support to form validation #13

merged 4 commits into from
Dec 14, 2017

Conversation

tirli
Copy link
Contributor

@tirli tirli commented Dec 12, 2017

Relates to #12

@codecov-io
Copy link

codecov-io commented Dec 12, 2017

Codecov Report

Merging #13 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   91.66%   91.76%   +0.09%     
==========================================
  Files           6        6              
  Lines          84       85       +1     
==========================================
+ Hits           77       78       +1     
  Misses          7        7
Impacted Files Coverage Δ
packages/neoform-validation/src/formValidation.js 97.43% <100%> (ø) ⬆️
packages/neoform-validation/src/fieldValidation.js 90% <100%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47c606...d3bef33. Read the comment docs.

Copy link
Contributor

@deepsweet deepsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, please fix a small typo.

readme.md Outdated
Where:

* `value` – field value for validation
* `type` – event type. Can be `submit`, `change`, `blur` or anythin you will provide to field `validate` method
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anythinG

@tirli
Copy link
Contributor Author

tirli commented Dec 13, 2017

@deepsweet fixed :)

@deepsweet deepsweet merged commit d42733c into zero-plus-x:master Dec 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants