Transform Main.hs into Tests #1
Conversation
This is a non-ideal implementation which relies on UndecidableInstances and orphan instances.
This avoids UndecidableInstances and TypeApplications in favor of simple newtypes.
|
My understanding is that this can only be reasonably tested in the servant-server and servant-client packages. I was peeking at type-spec and tao, but I don't think this would be the place to introduce them, even if there was consensus on that. For now this is only the server part, I'll look into the client part as soon as I find time. CONTRIBUTING.md mentioned -Werror-compatibility to check ghc 7.8 and 7.10 compatibility. I searched the web, but couldn't figure out what it means. I ran stylish and hlint though. |
|
I think I found an issue with the current implementation. servant-client interprets responses with status 301 as an error and gives us a I added a test for the current behaviour and a comment, since I think changing that is out of scope for this PR. |
|
BTW, the tests for servant-http-streams seem to be broken or need some more setup that I can't figure out 😐 |
|
@fisx highlighting you since you seem to have done most work on the uverb branch. |
|
thanks! i'll take a look at this soon, very happy to see that you're picking this up! :) |
There was a problem hiding this comment.
I left some nit-picks, but I'll merge this anyway because it's a step towards checking another box in the main PR. Up to you if you want to open another PR.
I agree and left this as a new check-box in the main PR.
I also agree that there isn't much to test in the servant package.
I couldn't find anything on -Werror-compatible either, so I suppose as long as we're passing the CI it's fine. :)
| :<|> emptyServer | ||
| :<|> (\shouldRedirect -> if shouldRedirect | ||
| then respond (WithStatus @301 ("redirecting" :: Text)) | ||
| else respond (WithStatus @200 alice )) |
There was a problem hiding this comment.
| else respond (WithStatus @200 alice )) | |
| else respond (WithStatus @200 alice)) |
| -- Right response -> | ||
| -- case response of | ||
| -- Z (Identity (WithStatus person :: WithStatus 200 Person)) -> | ||
| -- fail "Expected to be redirected" | ||
| -- S (last) -> | ||
| -- let Identity (WithStatus message :: WithStatus 301 Text) | ||
| -- = unZ last | ||
| -- in message `shouldBe` "redirecting" |
There was a problem hiding this comment.
| -- Right response -> | |
| -- case response of | |
| -- Z (Identity (WithStatus person :: WithStatus 200 Person)) -> | |
| -- fail "Expected to be redirected" | |
| -- S (last) -> | |
| -- let Identity (WithStatus message :: WithStatus 301 Text) | |
| -- = unZ last | |
| -- in message `shouldBe` "redirecting" | |
| -- Right (Z (Identity (WithStatus person :: WithStatus 200 Person)) -> | |
| -- fail "Expected to be redirected" | |
| -- Right (S last) -> | |
| -- let Identity (WithStatus message :: WithStatus 301 Text) = unZ last | |
| -- in message `shouldBe` "redirecting" |
(you could collapse the nexted cases in the actual test as well if you like, but i agree, that code shouldn't make it out of the uverb-branch.)
|
Thanks again! |
* Create tests from the Example.hs
Hi 👋
I started converting the Main.hs from the checklist in the main PR into tests. I don't have a lot of experience with larger Haskell projects, so any feedback is appreciated.