Review fixes

zeroc-ice · Jan 7, 2025 · afe7ec4 · afe7ec4
1 parent 612b96e
commit afe7ec4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/ruby/src/IceRuby/Communicator.cpp b/ruby/src/IceRuby/Communicator.cpp
@@ -43,8 +43,7 @@ IceRuby_Communicator_mark(void* p)
 extern "C" void
 IceRuby_Communicator_free(void* p)
 {
-    auto communicator = static_cast<Ice::CommunicatorPtr*>(p);
-    delete communicator;
+    delete static_cast<Ice::CommunicatorPtr*>(p);
 }
 
 static const rb_data_type_t IceRuby_CommunicatorType = {

diff --git a/ruby/src/IceRuby/ImplicitContext.cpp b/ruby/src/IceRuby/ImplicitContext.cpp
@@ -23,7 +23,6 @@ static const rb_data_type_t IceRuby_ImplicitContextType = {
     .function =
         {
             .dfree = IceRuby_ImplicitContext_free,
-
         },
     .flags = RUBY_TYPED_FREE_IMMEDIATELY,
 };

diff --git a/ruby/src/IceRuby/ValueFactoryManager.cpp b/ruby/src/IceRuby/ValueFactoryManager.cpp
@@ -51,6 +51,7 @@ static const rb_data_type_t IceRuby_ValueFactoryManagerType = {
     .wrap_struct_name = "Ice::ValueFactoryManager",
     .function =
         {
+            .dmark = IceRuby_ValueFactoryManager_mark,
             .dfree = IceRuby_ValueFactoryManager_free,
         },
     .flags = RUBY_TYPED_FREE_IMMEDIATELY,
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,7 +23,6 @@ static const rb_data_type_t IceRuby_ImplicitContextType = { @@
         .function =
             {
                 .dfree = IceRuby_ImplicitContext_free,
             },
         .flags = RUBY_TYPED_FREE_IMMEDIATELY,
     };
@@ Expand Down @@