Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slice2cs generates invalid namespace qualification #122

Closed
pepone opened this issue Jun 26, 2018 · 0 comments
Closed

slice2cs generates invalid namespace qualification #122

pepone opened this issue Jun 26, 2018 · 0 comments
Assignees
Milestone

Comments

@pepone
Copy link
Member

pepone commented Jun 26, 2018

The following Slice code generates invalid C# code with both 3.6.4 and 3.7.1


module test
{

class Point
{
};

};

module Foo
{

module test
{

module Bar
{

interface Canvas
{
   void drawPoint(test::Point p);
};

};

};

};

The generated code will lookup for Point in Foo::test rather than ::test

namespace Foo
{
    namespace test
    {
        namespace Bar
        {
            [_System.CodeDom.Compiler.GeneratedCodeAttribute("slice2cs", "3.6.4")]
            public interface CanvasPrx : Ice.ObjectPrx
            {
                void drawPoint(test.Point p);

We should always use global:: for full qualified names

@pepone pepone added this to the 3.7.2 milestone Jun 26, 2018
@pepone pepone self-assigned this Jun 26, 2018
pepone added a commit to pepone/ice that referenced this issue Jun 28, 2018
Add support to map Slice modules to different namespaces
using cs:namespace metadata

Fixes zeroc-ice#122 slice2cs generates invalid namespace qualification
@pepone pepone closed this as completed in b376340 Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant