Include only Ice and IceMX modules with Python package #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Jul 11, 2024
python/msbuild/ice.proj
Outdated
| ..\..\slice\IceBox\*.ice; | ||
| ..\..\slice\IceGrid\*.ice; | ||
| ..\..\slice\IceStorm\*.ice"/> | ||
| <SliceCompile Include="..\..\slice\Ice\Metrics.ice"/> |
There was a problem hiding this comment.
It's not clear why we have this special handling for Metrics.ice. Add a comment in there?
There was a problem hiding this comment.
I will, it is because for Ice we run with --no-package as the Ice/init.py file is not manually generated. For Metrics we want the generated IceMX/__init__.py.
| 'Ice', | ||
| 'IceBox', | ||
| 'IceGrid', | ||
| 'IceMX', |
There was a problem hiding this comment.
What are all the slice packages, and should we include them?
There was a problem hiding this comment.
This is to include the Slice files in the packages directory. I will check if there is a better alternative.
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python side of #2461