Matlab cleanup #2464
Merged
Matlab cleanup #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Jul 11, 2024
| @@ -1,14 +0,0 @@ | |||
| % CloseCallback Summary of CloseCallback | |||
There was a problem hiding this comment.
We don't map this feature to MATLAB.
| @@ -19,18 +18,4 @@ | |||
| % Compress the batch requests if at least one request was made on a compressed proxy. | |||
| BasedOnProxy (2) | |||
| end | |||
| methods(Static) | |||
There was a problem hiding this comment.
This is a helper function for decoding enums.
| namespace IceMatlab | ||
| { | ||
| mxArray* createStringFromUTF8(const std::string&); | ||
| std::string getStringFromUTF16(mxArray*); | ||
| mxArray* createEmpty(); |
There was a problem hiding this comment.
All these functions weren't called anywhere, and I am not in favor of keeping unused code just in case we may need it in the future.
externl
approved these changes
Jul 11, 2024
pepone
approved these changes
Jul 11, 2024
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused code in Ice for MATLAB. It also removes the generateds comments for code that is no longer generated.