Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw non local exceptions from TcpAcceptor #2704

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Do not throw non local exceptions from TcpAcceptor #2704

merged 1 commit into from
Sep 4, 2024

Conversation

pepone
Copy link
Member

@pepone pepone commented Aug 30, 2024

Replaces #2703

@pepone pepone requested a review from bernardnormier August 30, 2024 16:06
bernardnormier
bernardnormier approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I don't understand how the previous code worked since we were (re)throwing a System.Net.Sockets.SocketException and the code calling accept in ConnectionFactory does not catch this exception.

@pepone
Copy link
Member Author

pepone commented Sep 4, 2024

I don't understand how the previous code worked since we were (re)throwing a System.Net.Sockets.SocketException

Unless I'm missing something, the previous code wrapped System.Net.Sockets.SocketException in Ice.SocketException and it was handled in connection factory as a local exception.

@pepone pepone merged commit 200dada into zeroc-ice:main Sep 4, 2024
16 of 18 checks passed
@pepone pepone mentioned this pull request Sep 5, 2024
Closed
InsertCreativityHere pushed a commit to InsertCreativityHere/compiler-comparison that referenced this pull request Jan 1, 2025
@pepone
HEAD:(zeroc-ice/ice@200dada8c8) Do not throw non local exceptions fro…
dc5c8d3 
…m TcpAcceptor (zeroc-ice/ice#2704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardnormier bernardnormier bernardnormier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepone @bernardnormier