Add Publish target for C# builds and upgrade NuGet packages #3451
Conversation
|
|
||
| ```shell | ||
| msbuild msbuild\ice.proj /t:BuildDist | ||
| ``` |
There was a problem hiding this comment.
BuildDist was used before when we have separate targets for sources and tests. Now is just an alias for Build.
There was a problem hiding this comment.
I'd rather remove BuildDist and not keep it as an alias for Build.
There was a problem hiding this comment.
Ok, I would in a follow up PR, need to fix CI builds that relay in all languages to provide a BuildDist target.
| </PropertyGroup> | ||
|
|
||
| <Choose> |
There was a problem hiding this comment.
The properties below were used to find slice2cs in different platforms. With the new package we will always use the Slice compiler included in the NuGet package.
There was a problem hiding this comment.
In the future when we publish to NuGet Gallery, will be include binaries for Linux, macOS, and Windows?
There was a problem hiding this comment.
Need to add a platform subdir like we do in IceRPC.
I would deal with this in a follow up PR. |
|
|
||
| ```shell | ||
| msbuild msbuild\ice.proj /t:BuildDist | ||
| ``` |
There was a problem hiding this comment.
I'd rather remove BuildDist and not keep it as an alias for Build.
| You can publish the package to your local `global-packages` source with the following command: | ||
|
|
||
| ```shell | ||
| dotnet msbuild msbuild\ice.proj /t:Publish |
There was a problem hiding this comment.
For a follow-up PR: is there anyway we can switch to "dotnet build" and not need the msbuild/ice.proj argument?
There was a problem hiding this comment.
We need MSBuild for the C++ dependencies. If we build then separately it would be fine to use dotnet.
This PR upgrades C# NuGet packages to include slice2cs compiler in all builds. The PR also adds a new MSBuild target
Publishto publish the NuGet package to the localglobal-packagessource.The BUILDING.md has been updated to reflect this changes.