IceGrid/activation test fixes #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Jan 30, 2025
| } | ||
| catch (const Ice::NoEndpointException&) | ||
| { | ||
| this_thread::sleep_for(chrono::milliseconds(500)); | ||
| continue; | ||
| } | ||
| } | ||
| test(admin->isServerEnabled("server2")); | ||
| waitForServerState(admin, "server2", IceGrid::ServerState::Active); |
There was a problem hiding this comment.
With the previous code, we can exit the loop after getting NoEndpointException if the server just get enabled before we send the next ice_ping request.
In this situation waitForServerState would hang as there is no request activating the server.
pepone
commented
Jan 30, 2025
| } | ||
| } | ||
| test(admin->isServerEnabled("server2")); | ||
| waitForServerState(admin, "server2", IceGrid::ServerState::Active); | ||
| obj->ice_ping(); |
There was a problem hiding this comment.
This ice_ping request after the server is already activate and before is stopped doesn't make sense. Maybe it was mean to be done before the waitForServerState.
pepone
changed the title
externl
approved these changes
Jan 30, 2025
| } | ||
| catch (const Ice::NoEndpointException&) | ||
| { | ||
| this_thread::sleep_for(chrono::milliseconds(500)); | ||
| continue; |
bernardnormier
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3447