Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find-all-issues.rb #102

Closed
yegor256 opened this issue Jul 15, 2024 · 7 comments · Fixed by #381
Closed

find-all-issues.rb #102

yegor256 opened this issue Jul 15, 2024 · 7 comments · Fixed by #381
Assignees
@Yegorov
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@yegor256
Copy link
Member

Let's add a new judge, which will take the smallest issue in a repository (using issue-was-opened facts) and then add more facts, with smaller numbers. Such issues definitely exist in the repository, anyway.
@yegor256 yegor256 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 15, 2024
@Yegorov
Copy link
Contributor

Yegorov commented Jul 30, 2024

which will take the smallest issue in a repository

What the means "smallest issue"?

with smaller numbers

What is it? (maybe issue without comments?)

@yegor256 Can you give more information about this?

@yegor256
Copy link
Member Author

@Yegorov first, we scan all issue-was-opened facts and find the smallest value of their issue properties. This is the "smallest issue" in the repository that we are aware of. However, this is not the smallest number in GitHub: there are smaller numbers too. This happens because github-events.rb doesn't scan all events, but only the latest 1000 (or so). In order to fix this, we should add issue-was-opened events to the factbase, pretending we've seen them in github-events (even though we haven't).

@Yegorov
Copy link
Contributor

Yegorov commented Oct 8, 2024

@yegor256 may I take this one?

@yegor256
Copy link
Member Author

yegor256 commented Oct 8, 2024

@Yegorov sure, please!

@Yegorov Yegorov mentioned this issue Oct 10, 2024
Merged
Yegorov added a commit to Yegorov/judges-action that referenced this issue Oct 10, 2024
@Yegorov
zerocracy#102: implement find-all-issues judge
675f4cc
@Yegorov Yegorov mentioned this issue Oct 10, 2024
Merged
Yegorov added a commit to Yegorov/judges-action that referenced this issue Oct 11, 2024
@Yegorov
zerocracy#102: update fbe gem
d7e32c7
Yegorov added a commit to Yegorov/judges-action that referenced this issue Oct 11, 2024
@Yegorov
zerocracy#102: fix after in find-all-issues
73d2361
Yegorov added a commit to Yegorov/judges-action that referenced this issue Oct 13, 2024
@Yegorov
zerocracy#102: ignore delete not found issue
c467dcc
Yegorov added a commit to Yegorov/judges-action that referenced this issue Oct 13, 2024
@Yegorov
zerocracy#102: add test for check duplicate for find-all-issues
a9849f9
@yegor256
Copy link
Member Author

@rultor release, tag is 0.0.55

@rultor
Copy link
Contributor

rultor commented Oct 14, 2024

@rultor release, tag is 0.0.55

@yegor256 OK, I will release it now. Please check the progress here.

@rultor
Copy link
Contributor

rultor commented Oct 14, 2024

@rultor release, tag is 0.0.55

@yegor256 Done! FYI, the full log is here (took me 7min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yegorov Yegorov

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#102: implement find-all-issues judge Yegorov/judges-action
3 participants
@yegor256 @Yegorov @rultor