#189 add average_build_mttr into QoS
#317
Conversation
|
@Yegorov @tank-bohr please review |
| Fbe.unmask_repos.each do |repo| | ||
| Fbe.octo.repository_workflow_runs(repo, created: ">#{f.since.utc.iso8601[0..9]}")[:workflow_runs].each do |json| | ||
| workflow_id = json[:workflow_id] | ||
| if json[:conclusion] == 'failure' |
There was a problem hiding this comment.
@Suban05 What if the status is failure several times in a row. E. g.:
| id | workflow_id | status |
|---|---|---|
| 1 | 1 | success |
| 2 | 1 | failure |
| 3 | 1 | failure |
| 4 | 1 | success |
last_failed_at - should be the first or last (id: 2 or 3 ) failure of workflow run?
There was a problem hiding this comment.
@Yegorov good point, thanks
There was a problem hiding this comment.
@Yegorov added changes and a test, take a look, please
There was a problem hiding this comment.
I believe we must take the first failure. MTTR means "mean time to repair."
| Fbe.unmask_repos.each do |repo| | ||
| Fbe.octo.repository_workflow_runs(repo, created: ">#{f.since.utc.iso8601[0..9]}")[:workflow_runs].each do |json| | ||
| workflow_id = json[:workflow_id] | ||
| if json[:conclusion] == 'failure' |
There was a problem hiding this comment.
I believe we must take the first failure. MTTR means "mean time to repair."
|
@Yegorov @tank-bohr updated |
|
@Yegorov updated |
|
@yegor256 please check |
|
@Suban05 thanks! |
|
@tank-bohr Hey there, awesome job on the review! 🎉 You've snagged +4 points, which is pretty cool considering all the factors that go into calculating these bonuses. Your total score is now sitting at a sweet +137. Keep up the great work, and remember, more detailed reviews with plenty of comments could boost your points even higher next time! |
|
@Suban05 Hey there, awesome job on your contribution! 👍 You've earned +4 points, which is our base reward. We had to deduct 8 points because your code was quite hefty (501 hits-of-code, over our 200 limit), and another 4 points due to the high number of review comments (23). But don't worry, we added 13 points to make sure you get something for your hard work. Your total balance is now +565. Remember, quality over quantity is key. Keep those contributions coming, and aim for more concise, well-reviewed code next time! |
Closes #189