Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#191: calculate average review comments size for pr #329

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

Yegorov
Copy link
Contributor

@Yegorov Yegorov commented Sep 5, 2024

Closes #191
Fail, because need merge zerocracy/fbe#93 first

@Yegorov
Copy link
Contributor Author

Yegorov commented Sep 5, 2024

@Suban05 please review

Copy link
Contributor

@Suban05 Suban05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yegorov looks good

@Yegorov
Copy link
Contributor Author

Yegorov commented Sep 6, 2024

@yegor256 please check

1 similar comment
@Yegorov
Copy link
Contributor Author

Yegorov commented Sep 8, 2024

@yegor256 please check

@yegor256 yegor256 merged commit e8c219e into zerocracy:master Sep 8, 2024
8 checks passed
@yegor256
Copy link
Member

yegor256 commented Sep 8, 2024

@Yegorov thanks!

@0crat
Copy link

0crat commented Sep 8, 2024

@Suban05 Hey there! 👋 Thanks for your review! You've earned +4 points this time. Here's the breakdown: +4 base points, -10 for having only 2 comments (policy suggests at least 6), and +10 to keep you motivated. Remember, more comments can boost your score next time! Your running balance is now +341. Keep up the good work and aim for those bonus points! 💪

@0crat
Copy link

0crat commented Sep 8, 2024

@Yegorov Hey there, great job on your contribution! 🎉 You've racked up 7 points for this one: 4 as the base, plus a nice boost for your 149 hits-of-code. We did have to deduct 4 points due to only having 3 comments during review - remember, more feedback helps everyone! Keep the code coming, and maybe aim for 6+ comments next time to avoid that deduction. Your balance is now at +329. Let's see if we can push that even higher with your next contribution. Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

average_review_size for QoS
4 participants