Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify http query array parsing #4637

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Feb 8, 2025

No description provided.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (8690859) to head (0ee9eb3).
Report is 260 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
core/mapping/fieldoptions.go 100.00% <ø> (ø)
core/mapping/unmarshaler.go 96.18% <100.00%> (-0.31%) ⬇️
core/mapping/utils.go 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

@kevwan kevwan merged commit f747585 into zeromicro:master Feb 8, 2025
6 checks passed
@kevwan kevwan deleted the chore/refactor branch February 8, 2025 17:00
@xuerbujia
Copy link
Contributor

xuerbujia commented Feb 10, 2025

If simply remove the comma array, then some users who are using this feature in version 1.7.5-1.8.0 and who do not have the condition mentioned in #4629 will not be able to upgrade to a later version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants