Problem: zsock options could be available at build time but not at runtime #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntime Solution: rework the sockopts compatibility layer to generate a runtime check together with the build time check. In case the runtime check fails, print an error stating what the minimum required is vs the runtime version. It could be argued that an assert should be used instead, but this follows the same principle as the existing implementation where options not available at buildtime are compiled to simply return 0 and be no-ops, rather than asserting. Rework the sockopts.xml layout to let the options of each zmq version be grouped together in different and independent blocks to allow mix and match. Introduce a major_removed element to indicate in which version an option has been removed, to allow a finer granularity in the build time and run time checks.
Solution: run make code to regenerate
Solution: regenerate
|
Great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: rework the sockopts compatibility layer to generate a
runtime check together with the build time check. In case the runtime
check fails, print an error stating what the minimum required is vs
the runtime version. It could be argued that an assert should be used
instead, but this follows the same principle as the existing
implementation where options not available at buildtime are compiled
to simply return 0 and be no-ops, rather than asserting.
Rework the sockopts.xml layout to let the options of each zmq version
be grouped together in different and independent blocks to allow mix
and match. Introduce a major_removed element to indicate in which
version an option has been removed, to allow a finer granularity in
the build time and run time checks.
Fixes #1560
The retired options cannot be exposed in the public API unfortunately, as the bindings cannot cope with missing symbols.