Problem: zhashx_purge() seems to leak when shrinking #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: freen() the old self->items before reassigning to the newly allocated smaller one Signed-off-by: Jim Klimov <EvgenyKlimov@eaton.com>
|
Note: review desired, since this PR is more of an educated guess in debugging our component's issues (valgrind on Travis is ok against czmq-3.0.2 but reports multiple leaks against current master) - see e.g. https://travis-ci.org/42ity/fty-metric-composite/jobs/237155542 for details. UPDATE: Looked at 3.0.2 codebase now - it did the equivalent |
|
Also posted a self-test PR separately at #1676 - hopefully it would expose the problem (and later confirm the fix) on Travis too :) |
|
Yes it seems indeed the right thing to do. Thanks! |
|
yay, our project now passes with czmq4 and can deprecate requirement for czmq-3.0.2 :) |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: freen() the old self->items before reassigning to the newly allocated smaller one
Signed-off-by: Jim Klimov EvgenyKlimov@eaton.com