Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Use SIGTERM instead of SIGKILL #1853

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Conversation

diorcety
Copy link
Contributor

No description provided.

Problem: SIGKILL doesn't exist on Windows platform
Solution: Use SIGTERM which is the closest signal on the Windows platform
@sappo
Copy link
Member

sappo commented Feb 12, 2018

Thanks for your PR. For future contributions please follow our contributions guideline and describe the problem your commit solves and the solution you did implement.

So what's the problem with SIGKILL on windows and why use SIGTERM instead?

@bluca bluca merged commit c2b8100 into zeromq:master Feb 12, 2018
@bluca
Copy link
Member

bluca commented Feb 12, 2018

So what's the problem with SIGKILL on windows and why use SIGTERM instead?

SIGKILL doesn't exist on Windows, so it had to be redefined, but it was in a generated header which kept being stomped on by zproject, breaking the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants