Problem: zsys is re-initialized when logging an error in zsys_shutdown

[sappo]

Solution: Set the s_initialized variable to false only at the end of the
function instead of the beginning.

Fixes #2084

[bluca]

The problem with initializing at the end is that you then have a race with two threads going through init at the same time, no?

[sappo]

@bluca the issues was that the last error "Dangling socket" was asserted and not logged. Doron Somech <notifications@github.com> schrieb am Sa., 13. Juni 2020, 01:55:

…

Merged #2086 <#2086> into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2086 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADYNOSRRFCHJWKTRAZFODDRWK55VANCNFSM4N4QKM6A> .

[bluca]

@bluca the issues was that the last error "Dangling socket" was asserted and not logged. Doron Somech notifications@github.com schrieb am Sa., 13. Juni 2020, 01:55:
…
Merged #2086 <#2086> into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2086 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYNOSRRFCHJWKTRAZFODDRWK55VANCNFSM4N4QKM6A .

Right, but the problem now is that a second thread doing shutdown at the same time will block on the mutex, and then the mutex will be destroyed under it, which is undefined behaviour, and will break things badly

[sappo]

Okay, I'll look into it. Luca Boccassi <notifications@github.com> schrieb am Sa., 13. Juni 2020, 14:10:

…

@bluca <https://github.com/bluca> the issues was that the last error "Dangling socket" was asserted and not logged. Doron Somech ***@***.*** schrieb am Sa., 13. Juni 2020, 01:55: … <#m_1610995759582482379_> Merged #2086 <#2086> <#2086 <#2086>> into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2086 (comment) <#2086 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYNOSRRFCHJWKTRAZFODDRWK55VANCNFSM4N4QKM6A . Right, but the problem now is that a second thread doing shutdown at the same time will block on the mutex, and then the mutex will be destroyed under it, which is undefined behaviour, and will break things badly — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2086 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADYNOV4AOM6GQBAPAC3MYDRWNUE5ANCNFSM4N4QKM6A> .