Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmq_poller_add/zmq_poller_modify should reject invalid events arguments #3088

Closed
sigiesec opened this issue May 11, 2018 · 0 comments
Closed

Comments

@sigiesec
Copy link
Member

sigiesec commented May 11, 2018

Please use this template for reporting suspected bugs or requests for help.

Issue description

zmq_poller_add/zmq_poller_modify should reject invalid events arguments, rather than accepting them silently.

Environment

  • libzmq version (commit hash if unreleased): 4.2.5
  • OS: any

Minimal test code / Steps to reproduce the issue

void *ctx = zmq_ctx_new();
void *socket = zmq_socket(ctx, ZMQ_DEALER);
void *poller = zmq_poller_new();
int res = zmq_poller_add(poller, socket, nullptr, 42);

What's the actual result? (include assertion message & call stack if applicable)

res == 0

What's the expected result?

res == -1 && zmq_errno() == EINVAL

sigiesec added a commit to sigiesec/libzmq that referenced this issue May 14, 2018
…ntly

Solution: check and return an error on invalid arguments. Fixes zeromq#3088
sigiesec added a commit to sigiesec/libzmq that referenced this issue May 14, 2018
…ntly

Solution: check and return an error on invalid arguments. Fixes zeromq#3088
sigiesec added a commit to sigiesec/libzmq that referenced this issue May 14, 2018
…ntly

Solution: check and return an error on invalid arguments. Fixes zeromq#3088
sigiesec added a commit to sigiesec/libzmq that referenced this issue May 14, 2018
…ntly

Solution: check and return an error on invalid arguments. Fixes zeromq#3088
MohammadAlTurany pushed a commit to FairRootGroup/libzmq that referenced this issue Jan 28, 2019
…ntly

Solution: check and return an error on invalid arguments. Fixes zeromq#3088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant