Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

running test_pair_tcp_cap_net_admin without sudo access breaks terminal session #3725

Closed
bill-torpey opened this issue Oct 30, 2019 · 1 comment · Fixed by #3726
Closed

running test_pair_tcp_cap_net_admin without sudo access breaks terminal session #3725

bill-torpey opened this issue Oct 30, 2019 · 1 comment · Fixed by #3726

Comments

@bill-torpey
Copy link
Contributor

Issue description

running test_pair_tcp_cap_net_admin without sudo access breaks terminal session

Environment

  • libzmq version (commit hash if unreleased): e5a7f2e
  • OS: CentOS 7

Minimal test code / Steps to reproduce the issue

  1. run "make test" from a user w/o sudo access

What's the actual result? (include assertion message & call stack if applicable)

test_pair_tcp_cap_net_admin times out, and terminal session is unusable

What's the expected result?

Don't run test if user doesn't have sudo
@bluca
Copy link
Member

bluca commented Oct 30, 2019

@sigiesec we should probably add an option for this in cmake

bluca added a commit to bluca/libzmq that referenced this issue Oct 31, 2019
@bluca
Problem: test_pair_tcp_cap_net_admin requires sudo but is enabled by …
bfa8cf3 
…default in CMake

Solution: add an option to enable it, and default to false. Enable it in
the CI so we don't lose coverage, as it works on Travis.

Fixes zeromq#3725
@bluca bluca mentioned this issue Oct 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: test_pair_tcp_cap_net_admin requires sudo but is enabled by … bluca/libzmq
2 participants
@bluca @bill-torpey