Erasure of retired fd's in select.cpp causes an assertion in MSVC 2008 STL

[MikaelKjaer]

I was hitting an issue with an SCL enabled STL library in connection with the way select_t::loop was erasing retired fd's. The problem as identified by the SCL assertion was that by the time the iterator given to the erase method was called it was considered invalid by the library. I am not sure this isn't just a "quirk" of the MSVC STL library as the other code looks valid to me as well.

But I put in a more common way to perform the erase by getting a new valid iterator from it when it is done to continue with. I have run the patch on 32-bit Windows but there is nothing platform specific about the proposed solution:

    if (retired) {
        fd_set_t::iterator it = fds.begin();
        while (it != fds.end()) {
            if (it->fd == retired_fd) {
                it = fds.erase(it);
            }
            else {
                it++;
            }
        }
        retired = false;
    }

[sustrik]

Fixed in 59315eb