Fixed issue #1690 (ZMQ_REQ_RELAXED) #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ZMQ_REQ_RELAXED and a 'send' is executed after another 'send' the previous code would terminate the 'reply_pipe' if any. This is incorrect as terminating the reply pipe also terminates the send pipe as they are the same (a pipe associated with a socket is bidirectional). Doing a terminate on the pipe sets an internal flag called out_active to false and the pipe can no longer send messages. Removing the 'terminate' solves the problem. Removing this call is not an issue as the incorrect ordering of messages that could be incurred is taken care of by the ZMQ_REQ_CORRELATE option if needed.
c-rack
added a commit
that referenced
this pull request
Jan 1, 2016
Fixed issue #1690 (ZMQ_REQ_RELAXED)
|
Thanks. Do you think it would be possible to add a minimal test case based on your code in #1690, too? |
|
I guess I can. Give me a couple of days though, I am using a Java binding to do my testing so I would need to set the proper C++ environment to create the test case. (and thanks for merging, that was quick :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ZMQ_REQ_RELAXED and a 'send' is executed after another 'send' the
previous code would terminate the 'reply_pipe' if any.
This is incorrect as terminating the reply pipe also terminates the send pipe
as they are the same (a pipe associated with a socket is bidirectional).
Doing a terminate on the pipe sets an internal flag called out_active to false
and the pipe can no longer send messages.
Removing the 'terminate' solves the problem. Removing this call is not an issue
as the incorrect ordering of messages that could be incurred is taken care of
by the ZMQ_REQ_CORRELATE option if needed.