Mingw32 Compile #2268
Merged
Mingw32 Compile #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next time please follow the PR guidelines |
bluca
reviewed
Dec 22, 2016
| @@ -1,6 +1,6 @@ | |||
| CC=gcc | |||
| CFLAGS=-Wall -Os -g -DDLL_EXPORT -DFD_SETSIZE=16384 -DZMQ_USE_SELECT -I. | |||
| LIBS=-lws2_32 -lIphlpapi | |||
| LIBS=-lws2_32 -lIphlpapi -lsodium | |||
There was a problem hiding this comment.
why hardcoding libsodium? it should work with tweetnacl too and it should be an option
bluca
reviewed
Dec 22, 2016
| @@ -40,10 +40,10 @@ all: libzmq.dll | |||
| perf: inproc_lat.exe inproc_thr.exe local_lat.exe local_thr.exe remote_lat.exe remote_thr.exe | |||
|
|
|||
| libzmq.dll: $(OBJS) | |||
| g++ -shared -o $@ $^ -Wl,--out-implib,$@.a $(LIBS) | |||
| g++ -shared -static -O2 -s -o $@ $^ -Wl,--out-implib,$@.a $(LIBS) | |||
There was a problem hiding this comment.
Why hardcoding O2 and s? Usually they are defined by the environment, application makefiles should never explicitly define them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Notice
Before sending a pull request make sure each commit solves one clear, minimal,
plausible problem. Further each commit should have the following format:
Please avoid sending a pull request with recursive merge nodes, as they
are impossible to fix once merged. Please rebase your branch on
zeromq/libzmq master instead of merging it.
git remote add upstream git@github.com:zeromq/libzmq.git
git fetch upstream
git rebase upstream/master
git push -f
In case you already merged instead of rebasing you can drop the merge commit.
git rebase -i HEAD~10
Now, find your merge commit and mark it as drop and save. Finally rebase!
If you are a new contributor please have a look at our contributing guidelines:
CONTRIBUTING