Problem: Assertion failed in zmq::signaler_t::send

[10-5]

Solution: Change to the way it does below on non-Windows platforms, retry when send returns -1.

[bluca]

Thank you!

[hartcw]

I see a similar abort from zmq_connect() on windows, but the callstack shows it happens in zmq::signaler_t::recv().

I suspect a similar fix is needed there, to handle the case where ::recv() returns an unexpected value.

[bluca]

Could you please test a fix and send a PR, if it solves your problem?

[bjovke]

@nexcvon Are you sure that it's good to potentially loop forever if send () returns SOCKET_ERROR?
It is now the same behavior as before #2362 so it kind of reverts that PR.
Why should there be any asserts for failed send () if there's a possibility for it to fail?
assert () is used only to protect the program from highly irregular behavior. I'm not sure that failure on send () fits into that category...
And what are the guarantees that it will succeed if retried?
On Linux in the same function there's this code:

errno = EINTR;
break;

So it is possible to just set errno and return in case of send () error?
Furthermore, zmq_assert (nbytes == sizeof (dummy)); might also be the cause of troubles on Windows.
I'm not 100% familiar with libzmq internals, but if code looks strange on first sight there's a high potential that it actually is not good.