Problem SIGBUS under 64-bit SunOS Sparc #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: remove requirement to manually define macro and just check for the C++ supported version. Note that compiler intrinsics still have priority if available, to avoid changes unless necessary.
Solution: force the compiler to make the atomic_counter_t alignment friendly. This will ensure that the pointers inside the buffers allocated by shared_message_memory are aligned, at the cost of growing the memory size of atomic_counter_t from 4 to 8 bytes on 64 bit (when not using mutexes). Note that although content_t contains an atomic_counter_t, the compiler already padded the struct so there is no change in the buffer sizes used by the engines, save for the extra 4 bytes for the buffer's own single atomic counter. Fixes zeromq#2588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: see commits
Fixes #2588