Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: vc++ 11.0 (vs 2012) compile fails on move semantics. #2870

Merged
merged 3 commits into from
Dec 15, 2017

Conversation

evoskuil
Copy link
Contributor

@evoskuil evoskuil commented Dec 14, 2017

Solution: disable move semantics at the correct MSVC version.

@evoskuil
Copy link
Contributor Author

evoskuil commented Dec 15, 2017

NuGet packages for VS2013, VS2015, VS2017 are now published for version 4.2.3. NuGet package versions indicate 4.2.30 which is the result of a numbering mistake a while back in 4.2.x. Once we are past 4.2 it will be correct again.

@bluca
Copy link
Member

bluca commented Dec 15, 2017

What is the binary file builds/msvc/resource.rc ? Was it added by mistake?

@evoskuil
Copy link
Contributor Author

It's a text file, updated (not added) for the version number change. It's a GUI-generated (or manually) resource definition. Specifically in this case it contains file metadata for DLLs.

@bluca bluca merged commit 4e20c45 into zeromq:master Dec 15, 2017
@bluca
Copy link
Member

bluca commented Dec 15, 2017

Ah ok, thanks - for some reasons GitHub says it's a binary file so I got confused for a moment

@evoskuil
Copy link
Contributor Author

NP, maybe the extension and a BOM giving it trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants