Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent duplicate connections from PUB sockets also #2879

Merged
merged 1 commit into from
Dec 29, 2017
Merged

prevent duplicate connections from PUB sockets also #2879

merged 1 commit into from
Dec 29, 2017

Conversation

WallStProg
Copy link
Contributor

(see #788)

The original fix for the duplicate connect issue only covered SUB connecting to PUB, but the same problem exists in the other direction. (Irrespective of any other issues related to PUB connecting to SUB).

Note to Luca -- let me know if you need/want a test pgm for this, or if this behavior should be documented somewhere (e.g.in zmq_connect.txt?)

@bluca bluca merged commit cea6057 into zeromq:master Dec 29, 2017
@bluca
Copy link
Member

bluca commented Dec 29, 2017

Thanks! A PGM test sounds good - will be useful in any case. Adding more details to the docs sounds good as well.

@WallStProg
Copy link
Contributor Author

I meant test program, not PGM test ;-) I'll look at whipping something together -- assume that should go in tests directory. FWIW, I don't see anything there now that tests this feature.

As for docs, I'll put something in zmq_connect.txt, then if you want to move it elsewhere you can.

@bluca
Copy link
Member

bluca commented Dec 30, 2017

Yes the test directory is the right place. Can it be self-contained (provided libpgm is installed) or does it need some special setup in the system?

@WallStProg
Copy link
Contributor Author

Sorry it's taken so long ... finally had time to put together doc changes and a small test program -- please see #3117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants