Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: TIPC availability check is too strict #2977

Merged
merged 3 commits into from
Mar 9, 2018
Merged

Problem: TIPC availability check is too strict #2977

merged 3 commits into from
Mar 9, 2018

Commits on Mar 7, 2018

  1. Problem: CMake fails when test returns 77 (skip) 

    Solution: set property to let it mark the test as skipped as intended
    @bluca
    bluca committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    c2ba58c View commit details
    Browse the repository at this point in the history

  2. Problem: TIPC availability check is too strict 

    Solution: at build time only check if the API is available. In the tests
do a first check and a skip if the functionality is not available.

TIPC needs an in-tree but not loaded by default kernel module, tipc.ko
to be loaded, which requires root, so it is unlikely to be available on
any build system by default.
This will allow most distributions to ship with TIPC support built in,
and to avoid tests failure if the module is not there.
    @bluca
    bluca committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    e76149c View commit details
    Browse the repository at this point in the history

  3. Problem: no Travis tests for TIPC 

    Solution: mark one job with sudo: required and load the kernel module
    @bluca
    bluca committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    71aa3cd View commit details
    Browse the repository at this point in the history