Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for mingw cross-compilation #2983

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Fixes for mingw cross-compilation #2983

merged 2 commits into from
Mar 12, 2018

Commits on Mar 12, 2018

  1. Problem: certain windows header files are actually lowercase 

    Solution: change case of `WinSock2.h Iphlpapi.h Rpc.h` to match the
files on disk. This is only noticeable when cross-compiling from a
case-sensitive system so wouldn't get picked up in MSVC or mingw
builds running on a windows machine.

MSDN uses capitalised versions in prose and lowercase in code examples:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms737629(v=vs.85).aspx

Fixes zeromq#2978, the missing library message is a little misleading.
    @tonytheodore
    tonytheodore committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    794d7a3 View commit details
    Browse the repository at this point in the history

  2. Problem: mingw static/shared builds have different preprocessor defines 

    Solution: remove objects optimisation in library build (similar to zeromq#2860)
and set PUBLIC compile definitions on all static builds instead of MSVC
only.
    @tonytheodore
    tonytheodore committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    c7876c0 View commit details
    Browse the repository at this point in the history