Android Things 1.06 with Termux changes #3312

brubakerjeff · 2018-11-21T03:15:19Z

Please consider the following changes to the configuration scripts. After making the changes below ( macro to check for libatomic and enhanced verification for tipc[I don't have a tipc unit to verify with but inserted the line that was causing an error on this configuration into configure.ac]) I was able to compile with termux under Android 1.06 and succesfully use test cases

[still had to manually change configure script to use bash in this context but think that may normally be encapsulated in termux build scripts]
./configure --prefix=/data/data/com.termux/files/usr

This effort was necessitated to recompile libzmq from scratch in support of addressing this issue zeromq/pyzmq#1240

bluca · 2018-11-21T10:33:12Z

configure.ac

@@ -89,6 +89,8 @@ fi
 # Check whether to build a with debug symbols
 LIBZMQ_CHECK_ENABLE_DEBUG

+AC_CHECK_LIB([atomic],[__atomic_load_4],[LIBS="${LIBS} -latomic"]) 


This will always enable this linking, which is not right. There's a section that checks the host os, and looks for android, you should add it there instead with the appropriate checks for "android things"

bluca · 2018-11-21T14:04:45Z

thanks - please send a separate PR with a relicensing grant, see bottom of PR template: https://github.com/zeromq/libzmq/blob/master/.github/PULL_REQUEST_TEMPLATE.md

bluca · 2018-11-21T17:00:02Z

actually I double checked, and there's already an m4 test to see if linking to latomic is needed, so check the log instead and see why it is not triggering: https://github.com/zeromq/libzmq/pull/3083/files

brubakerjeff · 2018-11-21T17:02:51Z

Can I reply in this email? Is there a stakeholder for the tipc change? I don’t see a way to test the positive case (when tipc is present)

…

On Wed, Nov 21, 2018 at 12:00 PM Luca Boccassi ***@***.***> wrote: actually I double checked, and there's already an m4 test to see if linking to latomic is needed, so check the log instead and see why it is not triggering: https://github.com/zeromq/libzmq/pull/3083/files — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3312 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGPPbhRLV1JCtAPtp9fwZPUjRjTBf5E4ks5uxYamgaJpZM4YsUnb> .

bluca · 2018-11-21T17:05:29Z

the tipc change is fine, it's the latomic one that is not as it overwrites the work done by the linked pr in acinclude.m4

brubakerjeff · 2018-11-21T21:10:54Z

from configure
"checking for __atomic_load_4 in -latomic... yes"

which means this should be triggered.

[AC_MSG_RESULT(yes) ; libzmq_cv_has_atomic_instrisics="yes" LIBS="-latomic" ; $1],

My understanding is in the current version LIBS= was factored into the test case in the new change?

https://github.com/PIDriverAssist/libzmq/blob/4f48c5615ecbbd70423e163151a3448e75570f99/acinclude.m4#L694
[AC_MSG_RESULT(yes) ; libzmq_cv_has_atomic_instrisics="yes" ; $1],

changed at
https://github.com/PIDriverAssist/libzmq/commit/6de5f18be3baeccd2c7c4b095a1c09dbecb779a4#diff-a5522b90382504dc530177f63ced5209
Note is "with -latomic if needed however using LDFLAGS doesn't work when statically linking because LDFLAGS is added before LIBS"

If you can confirm my perception, a thought is to reinstate setting LIBS under condition that linking is not static?

bluca · 2018-11-21T21:16:27Z

LIBS is already been set (or rather, it's not reset back if it's needed), so the problem must be something else

bluca · 2018-11-21T21:20:31Z

if you build with make V=1 what's the actual content of *FLAGS?

brubakerjeff · 2018-11-21T21:36:28Z

from configure..
checking whether compiler supports __atomic_Xxx intrinsics... no
running make
$ make V=1
Making all in doc
make[1]: Entering directory '/data/data/com.termux/files/home/libzmq-3/libzmq/doc'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/data/data/com.termux/files/home/libzmq-3/libzmq/doc'
make[1]: Entering directory '/data/data/com.termux/files/home/libzmq-3/libzmq'
/bin/sh ./libtool --tag=CXX --mode=link g++ -pedantic -Werror -Wall -Wno-long-long -g -O2 -Wno-tautological-constant-compare -o tools/curve_keygen tools/curve_keygen.o src/libzmq.la -lrt -lpthread
libtool: link: g++ -pedantic -Werror -Wall -Wno-long-long -g -O2 -Wno-tautological-constant-compare -o tools/.libs/curve_keygen tools/curve_keygen.o src/.libs/libzmq.so -lrt -lpthread -Wl,-rpath -Wl,/usr/local/lib
/data/data/com.termux/files/usr/bin/arm-linux-androideabi-ld: src/.libs/libzmq.so: undefined reference to __atomic_fetch_sub_4' /data/data/com.termux/files/usr/bin/arm-linux-androideabi-ld: src/.libs/libzmq.so: undefined reference to __atomic_load_4'
/data/data/com.termux/files/usr/bin/arm-linux-androideabi-ld: src/.libs/libzmq.so: undefined reference to __atomic_exchange_4' /data/data/com.termux/files/usr/bin/arm-linux-androideabi-ld: src/.libs/libzmq.so: undefined reference to __atomic_compare_exchange_4'
/data/data/com.termux/files/usr/bin/arm-linux-androideabi-ld: src/.libs/libzmq.so: undefined reference to __atomic_fetch_add_4' /data/data/com.termux/files/usr/bin/arm-linux-androideabi-ld: src/.libs/libzmq.so: undefined reference to __atomic_store_4'
I'm reading this and seeing anywhere a state change would/could occur for LIBS to be concatenated with latomic. Per your statement it would occur previously in execution?
AC_DEFUN([LIBZMQ_CHECK_ATOMIC_INTRINSICS], [{
AC_MSG_CHECKING(whether compiler supports __atomic_Xxx intrinsics)
AC_LINK_IFELSE([AC_LANG_SOURCE([
/* atomic intrinsics test */
int v = 0;
int main (int, char **)
{
int t = __atomic_add_fetch (&v, 1, __ATOMIC_ACQ_REL);
return t;
}
])],
[AC_MSG_RESULT(yes) ; GCC_ATOMIC_BUILTINS_SUPPORTED=1 libzmq_cv_has_atomic_instrisics="yes" ; $1])

if test "x$GCC_ATOMIC_BUILTINS_SUPPORTED" != x1; then
save_LIBS=$LIBS
LIBS="$LIBS -latomic"
AC_LINK_IFELSE([AC_LANG_SOURCE([
/* atomic intrinsics test */
int v = 0;
int main (int, char **)
{
int t = __atomic_add_fetch (&v, 1, __ATOMIC_ACQ_REL);
return t;
}
])],
[AC_MSG_RESULT(yes) ; libzmq_cv_has_atomic_instrisics="yes" ; $1],
[AC_MSG_RESULT(no) ; libzmq_cv_has_atomic_instrisics="no" LIBS=$save_LIBS ; $2])
fi
}])
The host_os is reporting as linux-gnueabi not android for Android Things 1.06 worth considering depending upon directory for libc

bluca · 2018-11-21T22:09:16Z

are you passing all the cross compilation flags for autoconf?

brubakerjeff · 2018-11-21T22:10:19Z

I'm compiling on device. Would they be relevant? (Termux on android)

bluca · 2018-11-23T19:28:16Z

I'm not sure. I don't have the device to try it, so I'll merge as-is.

brubakerjeff · 2018-11-23T20:43:08Z

Thank you. I think we will need another iteration as we understand this more. I'm thinking the branches should condition upon presence of atomic intrinsic and whether or not libzmq is statically compiled [based upon the notes] (none of this logic is encapsulated by lower level tools?) but I will read more to confirm this.

bluca · 2018-11-24T16:51:45Z

Ok, feel free to send more pull requests

* include atomic when needed * update for tipc * moved check under android * added license

brubakerjeff added 2 commits November 20, 2018 20:46

include atomic when needed

412750a

update for tipc

7c3cb1b

bluca reviewed Nov 21, 2018

View reviewed changes

moved check under android

3fb0939

brubakerjeff closed this Nov 21, 2018

added license

4f48c56

brubakerjeff reopened this Nov 21, 2018

bluca merged commit d983251 into zeromq:master Nov 23, 2018

MohammadAlTurany pushed a commit to FairRootGroup/libzmq that referenced this pull request Jan 28, 2019

Android Things 1.06 with Termux changes (zeromq#3312)

ea0e7da

* include atomic when needed * update for tipc * moved check under android * added license

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android Things 1.06 with Termux changes #3312

Android Things 1.06 with Termux changes #3312

brubakerjeff commented Nov 21, 2018

bluca Nov 21, 2018

bluca commented Nov 21, 2018

bluca commented Nov 21, 2018

brubakerjeff commented Nov 21, 2018 via email

bluca commented Nov 21, 2018

brubakerjeff commented Nov 21, 2018

bluca commented Nov 21, 2018

bluca commented Nov 21, 2018

brubakerjeff commented Nov 21, 2018 •

edited

Loading

bluca commented Nov 21, 2018

brubakerjeff commented Nov 21, 2018 •

edited

Loading

bluca commented Nov 23, 2018

brubakerjeff commented Nov 23, 2018

bluca commented Nov 24, 2018

Android Things 1.06 with Termux changes #3312

Android Things 1.06 with Termux changes #3312

Conversation

brubakerjeff commented Nov 21, 2018

bluca Nov 21, 2018

Choose a reason for hiding this comment

bluca commented Nov 21, 2018

bluca commented Nov 21, 2018

brubakerjeff commented Nov 21, 2018 via email

bluca commented Nov 21, 2018

brubakerjeff commented Nov 21, 2018

bluca commented Nov 21, 2018

bluca commented Nov 21, 2018

brubakerjeff commented Nov 21, 2018 • edited Loading

bluca commented Nov 21, 2018

brubakerjeff commented Nov 21, 2018 • edited Loading

bluca commented Nov 23, 2018

brubakerjeff commented Nov 23, 2018

bluca commented Nov 24, 2018

brubakerjeff commented Nov 21, 2018 •

edited

Loading

brubakerjeff commented Nov 21, 2018 •

edited

Loading