Switching or desactivate wifi can crash Android application #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is right. The socket is dead if accept fails with that error. At the very least ifdef it for Android app that it doesn't cause issues on other systems. |
|
It seems reasonable, I pushed a correction to limit this behavior to Android. |
|
I think the whole expression has to be ifdeffed, it breaks the build: ../src/tcp_listener.cpp:311:1: error: embedding a directive within macro arguments is not portable [-Werror] Also please rebase and squash the fixups to avoid breaking bisect |
…code returned on Android. Solution: Avoid killing the application, allows to take the appropriate measures to this situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Switching or desactivate wifi can lead to have EINVAL error code on Android
Solution: do not abort when this error happen