Problem: use of malloc is error-prone

[sigiesec]

Solution: use std::vector instead, simplify control-flow

[sonatype-lift]

Persistent Bugs or Warnings (24)

Infer

1. DEAD_STORE
   • At src/tcp_address.cpp(121,5)
   • The value written to &max_port_str_length (type unsigned long const ) is never used.
2. DEAD_STORE
   • At src/tcp_address.cpp(288,5)
   • The value written to &max_mask_len (type unsigned long const ) is never used.
3. DEAD_STORE
   • At src/udp_engine.cpp(398,9)
   • The value written to &rc (type int) is never used.
4. DEAD_STORE
   • At tests/testutil_monitoring.cpp(342,9)
   • The value written to &pos (type char*) is never used.
5. MEMORY_LEAK
   • At src/radix_tree.cpp(407,1)
   • memory dynamically allocated by call to make_node() at line 340, column 11 is not reachable after line 407, column 1.
6. MEMORY_LEAK
   • At src/radix_tree.cpp(407,1)
   • memory dynamically allocated to current_node._data by call to resize at line 356, column 9 is not reachable after line 407, column 1.
7. MEMORY_LEAK
   • At src/radix_tree.cpp(527,1)
   • memory dynamically allocated to current_node._data by call to resize at line 448, column 9 is not reachable after line 527, column 1.
8. MEMORY_LEAK
   • At src/radix_tree.cpp(527,1)
   • memory dynamically allocated to parent_node._data by call to resize at line 477, column 9 is not reachable after line 527, column 1.
9. UNINITIALIZED_VALUE
   • At external/unity/unity.c(349,17)
   • The value read from buf[_] was never initialized.
10. UNINITIALIZED_VALUE
    • At src/stream_engine.cpp(79,13)
    • The value read from cred.gid was never initialized.
11. UNINITIALIZED_VALUE
    • At src/stream_engine.cpp(79,13)
    • The value read from cred.pid was never initialized.
12. UNINITIALIZED_VALUE
    • At src/stream_engine.cpp(79,13)
    • The value read from cred.uid was never initialized.
13. UNINITIALIZED_VALUE
    • At src/tweetnacl.c(138,15)
    • The value read from w[_] was never initialized.
14. UNINITIALIZED_VALUE
    • At src/tweetnacl.c(149,7)
    • The value read from x[_] was never initialized.
15. UNINITIALIZED_VALUE
    • At src/tweetnacl.c(575,18)
    • The value read from a[_] was never initialized.

[sonatype-lift]

Muse Analysis Complete

Analysis tools: [ Infer ] run on commits [ 1de4cf6 .. b5db4b4 ]