Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow library output name to be changed externally #3738

Merged
merged 2 commits into from
Nov 13, 2019

Conversation

eldruin
Copy link
Contributor

@eldruin eldruin commented Nov 13, 2019

Internally we rename the libraries we integrate as to avoid interference with the library versions already available on the target systems by giving them a prefix.
This PR allows users to specify, for example:

-DZMQ_OUTPUT_BASENAME:STRING=MYORG_zmq

I used BASENAME as the flavor and/or version are appended later.

Alternatively, it would be also fine for us to add a prefix variable like OUTPUT_NAME_PREFIX or so but I was unable to find a good name that cannot be confused the target PREFIX property (e.g. lib)

@bluca
Copy link
Member

bluca commented Nov 13, 2019

Thanks for the PR - please add a commit with a relicense statement https://github.com/zeromq/libzmq/blob/master/RELICENSE/README.md

@eldruin
Copy link
Contributor Author

eldruin commented Nov 13, 2019

@bluca done

@bluca bluca merged commit e0d9e21 into zeromq:master Nov 13, 2019
@eldruin eldruin deleted the external-output-name branch November 13, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants