-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Autotools-generated libzmq.pc
file
#4667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes cross-compiling for Windows with static linking.
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Mar 20, 2024
bluca
approved these changes
Mar 21, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Mar 23, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Mar 26, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Apr 3, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Apr 22, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Apr 23, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Apr 29, 2024
vasild
pushed a commit
to vasild/bitcoin
that referenced
this pull request
Apr 30, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
May 4, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
May 20, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jun 4, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jun 29, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jun 30, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 3, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 3, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 4, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 13, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 13, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 15, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 16, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 16, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 16, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 16, 2024
theuni
pushed a commit
to theuni/bitcoin
that referenced
this pull request
Jul 19, 2024
theuni
added a commit
to theuni/bitcoin
that referenced
this pull request
Jul 19, 2024
See zeromq/libzmq#4667. Co-authored-by: Cory Fields <cory-nospam-@coryfields.com>
theuni
added a commit
to theuni/bitcoin
that referenced
this pull request
Jul 19, 2024
See zeromq/libzmq#4667. Co-authored-by: Cory Fields <cory-nospam-@coryfields.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the master branch @ 481cc3f, cross-compiling for Windows with static linking fails when relying on the
libzmq.pc
file.Consider the minimum reproducible
zmq_win_demo.cpp
source file:and steps to reproduce the bug as follows:
This PR fixes this bug.
Please note that CMake-generated
libzmq.pc
file is also broken as its "Libs.private" section contains only-lstdc++
when cross-compiling for Windows. I leave this problem out of this PR scope.