Problem: create_ipc_wildcard_address can fail #4732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check and handle failure as a fallback to tcp
I believe this is the cause of #4730
There may be a better underlying fix to prevent the failure in the first place, but this treats failure to create the path for the ipc socket as a condition for falling back on tcp, just like failing to create the AF_UNIX socket itself, rather than ignoring the error and assuming success, which may fail later in epoll with EBADF.
I haven't been able to explain why this failure occurs in very peculiar scenarios (see #4730 and various linked issues through pyzmq), but this patch causes at least one of those cases to succeed, if I've done my tests correctly. Setting
$env:TMPto a nonexistent or non-writable directory seems to provoke it sometimes as well.