[DOC] warn about and de-emphasize send/recv_pyobj #2039
Merged
+292
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recv_pyobj is pickle.loads, which means arbitrary code execution - add warnings to docstrings, narrative docs - updates some ancient examples to not use pyobj, which gives the impression it's a good idea - add example of using signatures to authenticate messages before calling pickle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recv_pyobjispickle.loads, which means arbitrary code executionpickle.loadsThis stops short of outright deprecating
send/recv_pyobj, which I'm still considering.