Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft support not enabled by default #638

Open
antoniaelsen opened this issue Jul 1, 2024 · 4 comments
Open

Draft support not enabled by default #638

antoniaelsen opened this issue Jul 1, 2024 · 4 comments

Comments

@antoniaelsen
Copy link

antoniaelsen commented Jul 1, 2024

Describe the bug A clear and concise description of what the bug is.

ZMQ Draft support is not enabled by default in builds, despite the suggestion in the README

Quick ref:

npm_config_zmq_draft: false

'zmq_draft%': 'false',

Is the README technically incorrect or should the build scripts & config be updated? Can submit a PR to correct either way.

@aminya
Copy link
Member

aminya commented Jul 1, 2024

The draft is not enabled in the latest release yet. I plan to enable it in the upcoming release. The readme shows the dev status.

@antoniaelsen
Copy link
Author

antoniaelsen commented Jul 2, 2024

@aminya are the cli / .npmrc --zmq-draft and --build-from-source flags expected to work? I'm not convinced the zmq lib is being rebuilt when I'm using them, and when trying to use draft features (RADIO/DISH), I get

Error: ZeroMQ draft features are not enabled in this build. To enable support, (re)compile this library with --zmq-draft.

If this isn't expected, I can create a new issue and include more details (but succinctly: arm osx 13, node 20)

@aminya
Copy link
Member

aminya commented Jul 8, 2024

Building from the source first checks for the binaries. So, it doesn't build from the source in reality if the binaries already exist. You can work around this by removing the prebuilds folder. We should fix this though.

@aminya
Copy link
Member

aminya commented Oct 22, 2024

I have migrated the build to CMake/vcpkg. Now you can enable the Draft support through npmrc by building from the source.
https://github.com/zeromq/zeromq.js#draft-support

@aminya aminya added enhancement and removed bug labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants