Remove the non-deterministic module export modification in native.ts #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare cases (notably jest), if it reloads the module cache for every test-suite, all test-suites that are run after the first one will have the `methods` dict have the values {send: undefined, received: undefined, ...}, because the ./native module itself is reloaded, however the node-gyp-build module is not (hence has the aforementioned dict keys of Socket.prototype deleted => undefined).
Instead of spelunking into figuring out how to make the previous very-non-standard semantics work, this seems like a simpler and more robust solution.
|
Thanks @Eximius , i wasn't crazy |
|
I'd be happy to merge this; but there seem to be some unrelated changes included. Could you update the PR so only the relevant code bits are modified? |
|
I can remove the bumps, but the other changes would seemingly help in general? |
|
If there are any other issues you want to address feel free to open a separate pull request for them. Without any description it's not obvious why the other changes are needed. |
|
Hi @rolftimmermans and @Eximius, any new on this PR ? May i help to split commits? |
aminya
requested changes
Apr 18, 2021
aminya
reviewed
Sep 5, 2022
aminya
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases (notably jest), if it reloads the module cache for every test-suite, all test-suites that are run after the first one will have the
methodsdict have the values {send: undefined, received: undefined, ...}, because the ./native module itself is reloaded, however the node-gyp-build module is not (hence has the aforementioned dict keys of Socket.prototype deleted => undefined).Instead of spelunking into figuring out how to make the previous very-non-standard semantics work, the changes I introduce seem like a simpler and more robust solution.