Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context aware #482

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Context aware #482

merged 3 commits into from
Aug 25, 2022

Conversation

YZYLAB
Copy link

@YZYLAB YZYLAB commented Sep 3, 2021

Necessary for Electron 14.0

package.json Outdated Show resolved Hide resolved
@aminya aminya added the 4.x/5.x label Sep 29, 2021
@YZYLAB YZYLAB requested a review from aminya October 12, 2021 15:42
@nbabanov
Copy link

nbabanov commented Mar 23, 2022

What is the progress on this? Is there a reason for this to not be merged?

@aminya @captainsafia

@nbabanov
Copy link

nbabanov commented Apr 1, 2022

@JustinTulloss @lgeiger

@captainsafia
Copy link
Contributor

Stepping into this with no context (pun intended).

Necessary for Electron 14.0

Where is this documented?

Also, how do we validate this fix?

Not opposed to it on principle, but want to make sure I's are dotted and T's are crossed.

@YZYLAB
Copy link
Author

YZYLAB commented Apr 11, 2022

electron/electron#18397

Here they explained what they pushed in Electron 14.0

@nbabanov
Copy link

@captainsafia Could you provide any info?

@aminya aminya merged commit fcfd2bc into zeromq:5.x Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants