Remove cross-compilation arch flags for MacOS #622
Conversation
`CMAKE_OSX_ARCHITECTURES` is already set in `build.js`, so there's no need to set it in `binding.gyp`. In fact, if the architecture is inferred from the host (and not via the `$ARCH` env var), this previously resulted in incorrectly cross-compiling.
| 'OTHER_CFLAGS': [ | ||
| "<!(echo \"-arch ${ARCH:=x86_64}\")", | ||
| ], | ||
| 'OTHER_LDFLAGS': [ | ||
| "<!(echo \"-arch ${ARCH:=x86_64}\")", | ||
| ] |
There was a problem hiding this comment.
The gyp flags are used for ZeroMQ, and build.js is used for libzmq (the upstream library used by ZeroMQ). There's a subtle difference between these two that's sometimes confusion for new contributors.
There was a problem hiding this comment.
definitely confusing to me! Where does the ARCH value here supposedly come from? I was finding it to be blank (on my ARM mac)
There was a problem hiding this comment.
ARCH is defined in the CI or as an env variable in build.ts
There was a problem hiding this comment.
If ARCH is always defined, there should be no need for "<!(echo \"-arch ${ARCH:=x86_64}\")",. It seems odd too that we should have to override the flags instead of simply omitting them.
I'll create an issue for what I thought was a symptom of this.
|
Submitted as issue #632. I'm not sure why you closed this PR (not a problem? wrong fix?) - and I would have appreciated a comment to that effect. |
aminya
changed the title
CMAKE_OSX_ARCHITECTURESis already set inbuild.js, so there's no need to set it inbinding.gyp.$ARCHenv var), this previously resulted in incorrect cross-compiling.Fixes #632