Problem: curve keys getsockopt uninitialised read #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: always initialised zmq::options_t class variables arrays to
avoid reading uninitialised data when CURVE is not yet configured and
a getsockopt ZMQ_CURVE_{SERVER | PUBLIC | SECRET]KEY is issued.
Backport from libzmq.
Solution: use stable branch instead of the development branch, and also clone with --depth 1 to make it more efficient.
hintjens
added a commit
that referenced
this pull request
Feb 16, 2016
Problem: curve keys getsockopt uninitialised read
|
Nice. Would you also update NEWS to reference the issue? Thanks. |
|
Sure, but there is no issue in the tracker. Should I create one? |
|
Yes, please. To backport fixes we must have issues. That's the simplest way On Tue, Feb 16, 2016 at 2:54 PM, Luca Boccassi notifications@github.com
|
|
Ok, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: backport from zeromq/libzmq#1805 together with a small fix for Travis CI.