Problem: return code of sodium_init() is not checked. #69
Conversation
There are two todo comments in curve_client.cpp and curve_server.cpp that suggest checking the return code of sodium_init() call. sodium_init() returns -1 on error, 0 on success and 1 if it has been called before and is already initalized: https://github.com/jedisct1/libsodium/blob/master/src/libsodium/sodium/core.c
Problem: return code of sodium_init() is not checked.
|
Please do not make patches directly to stable releases, and @zeromq/libzmq-maintainers please do not merge these. @bkmit kindly make this patch/pull request to libzmq, and then we (or you) can backport it to zeromq4-1 with a test case, as we ask in our process. |
|
I've reverted this change, and to avoid future mishaps, changed permissions to stop merging into zeromq4-a and zeromq4-x. If we allow patches to flow directly to this repo then we lose them. The process for changing these repos is to backport selected fixes from master, and each backport needs:
That's covered by C4.1 here: http://rfc.zeromq.org/spec:22#toc8 No harm done here, and sorry for breaking the flow. @bkmit if there is some special reason this change shouldn't be done on master, let me know. |
|
This patch was cherry picked from libzmq: c-rack/libzmq@479db21 merged long ago. |
|
Ah, I didn't realize it was a backport... checked the latest commits on libzmq and it wasn't there. My apologies. You did it right except (a) please mention it's a backport and (b) specify the issue, and if there's none, please make one. The release notes for a stable release are a list of issues fixed, and every backport must have an issue. I guess a PR number on libzmq does count as an issue. |
|
If you need it, I'll make a new stable release once this is backported. The test case is to confirm we've not broken the stable release. If you want to confirm that manually by testing it after the patch is applied, that's fine here. |
|
I'm not member of stable maintainers team. Can I ask for more knowledgable people to backport this patch in proper way? And, yes, stable release is very welcome! |
|
OK, I've canceled my revert. Your patch is good. For this to be accepted into zeromq4-1 I need an issue. If you would please make an issue on libzmq, and indicate that the fix is in libzmq, and in zeromq4-1, then we're good to go. |
|
There is already an issue in libzmq: zeromq/libzmq#1632 |
|
Look like @sthen already opened issue zeromq/libzmq#1632 |
|
OK, all good, thanks. On Wed, Nov 4, 2015 at 10:00 AM, Constantin Rack notifications@github.com
|
|
With the latest 4.1.3 tarball and gcc5.2 this fails the build On Wed, Nov 4, 2015 at 3:02 AM, Pieter Hintjens notifications@github.com
|
There are two todo comments in curve_client.cpp and curve_server.cpp that suggest
checking the return code of sodium_init() call. sodium_init() returns -1 on error,
0 on success and 1 if it has been called before and is already initalized:
https://github.com/jedisct1/libsodium/blob/master/src/libsodium/sodium/core.c