Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_name of a peer #297

Closed
sphaero opened this issue Dec 18, 2014 · 2 comments
Closed

get_name of a peer #297

sphaero opened this issue Dec 18, 2014 · 2 comments

Comments

@sphaero
Copy link
Contributor

sphaero commented Dec 18, 2014

There seems to be no such method. There's get_name which returns its own name and there's get_peers() which returns a list of uuids.

Adding a get_name(peer_id) method would be useful as zyre_node does know this.
sphaero added a commit to sphaero/pyre that referenced this issue Dec 29, 2014
@sphaero
suggested fix for zeromq#43 and zeromq/zyre#297
c01ebf4
@sphaero
Copy link
Contributor Author

sphaero commented Dec 29, 2014

I've implemented a suggested fix in Pyre: sphaero/pyre@c01ebf4
Could also make patch for Zyre. Any objections to this approach?

@hintjens
Copy link
Member

Sounds good.

On Mon, Dec 29, 2014 at 2:44 PM, Arnaud Loonstra notifications@github.com
wrote:

I've implemented a suggested fix in Pyre: sphaero/pyre@c01ebf4
sphaero/pyre@c01ebf4
Could also make patch for Zyre. Any objections to this approach?

—
Reply to this email directly or view it on GitHub
#297 (comment).

hintjens added a commit that referenced this issue Dec 29, 2014
@hintjens
Merge pull request #298 from sphaero/feature_peer_name
2092be7 
added zyre_get_peer_name method, fixes #297
hintjens added a commit that referenced this issue Dec 29, 2014
@hintjens
Revert "added zyre_get_peer_name method, fixes #297"
ff53943
sphaero added a commit to zeromq/pyre that referenced this issue Jan 26, 2015
@sphaero
Merge pull request #47 from sphaero/feature_get_peer_name
2f14ddb 
suggested fix for #43 and zeromq/zyre#297
@sphaero sphaero mentioned this issue Jan 2, 2017
Closed
@sthoduka sthoduka mentioned this issue Dec 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hintjens @sphaero