forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 0
Add external swapper #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zeroorhero
wants to merge
8
commits into
main
Choose a base branch
from
add-external-swapper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28acb63 to
9009e50
Compare
When we create the llm engine, we support specifying the type of external swapper and the size of the media type. Currently, only local files are supported. Developers can customize the format type of the external swapper. For example, the format of the file is "file://path/to/directory". And supports users to add their own external swapper. Change-Id: I7989e7aba32ad218629c067fc984c8744c25ab64 Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
ff06ee6 to
2d264a2
Compare
Firstly, two methods determine_num_external_available_blocks and initialize_external_cache are added to determine the number of external blocks and perform initialization operations when vllm-engine is started. Then, according to the scheduling results of shceduler, the blocks that need to be swapped are divided into two types: CPU and External, and then the block swap operation is performed. Change-Id: I155439e6a8af21ae2241c3eba892f82b7c03fcb2 Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
2d264a2 to
3826021
Compare
In the previous version of schedule, the blocks_to_swap_out field in the return result only has the mapping of GPU to CPU block id. However, after adding devices other than CPU, it is necessary to distinguish different devices, so device related information is added to this field. At the same time, external swapper related methods are added to scheduler and BlockManager, and corresponding implementations are made. Change-Id: Iaec7fd7df17fa99c06bfc94d6cb314f44bc04522 Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
The ExternalSwapperBase interface is extracted, and users can implement their own ExternalSwapper. ExternalSwapperBase corresponds one-to-one with cache_engine and The interaction between cache_engine and external swapper can be called into the specific implementation class of the corresponding external swapper. Change-Id: I585520bda1298bcb32e501d5f090299e4a21e1ad Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
Implementing external swapper for local file. Change-Id: Ia57e8b62c68ea9f32cb03d29047131194fa245a8 Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
3826021 to
68216ee
Compare
Add swap_out_to_local_file and swap_in_from_local_file kernels their and corresponding tests and benchmarks. Change-Id: I222a819ee57a5604d5b1e9a61c5614d3208ef251 Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
Added num_cumulative_preemption and external_cache_usage_sys indicators to metrics Change-Id: Id7f9c811cb3874e989b596ef9dbaa8b91442f875 Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
benchmark_throughput support external swapper configuration. Change-Id: Ib139ab8fb2c63aecf80a5251f855cdbb14b3da41 Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
68216ee to
91b4789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FILL IN THE PR DESCRIPTION HERE
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]For changes on the vLLM frontend (e.g., OpenAI API server,LLMclass, etc.)[Kernel]for changes affecting CUDA kernels or other compute kernels.[Core]for changes in the core vLLM logic (e.g.,LLMEngine,AsyncLLMEngine,Scheduler, etc.)[Hardware][Vendor]for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.shto format your code.docs/source/if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-requiredand might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-requiredlabel on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!