Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test for minimal dependencies #844

Merged
merged 1 commit into from
Oct 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/sisl/viz/processors/tests/test_geometry.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ def some_property(geometry, bonds):
), f"Wrong value for {k}"


@pytest.mark.xfail(reason="unknown failure on minimal version dependencies")
def test_add_xyz_to_bonds_dataset(geometry):
bonds = find_all_bonds(geometry, 1.5)

Expand All @@ -275,7 +274,7 @@ def test_add_xyz_to_bonds_dataset(geometry):
assert isinstance(xyz_bonds, xr.Dataset)
assert "xyz" in xyz_bonds.data_vars
assert xyz_bonds.xyz.shape == (len(bonds.bonds), 2, 3)
assert np.allclose(xyz_bonds.xyz[:, 0], geometry.xyz[bonds.bonds[:, 0]])
assert np.allclose(xyz_bonds.xyz[:, 0], geometry.xyz[np.ravel(bonds.bonds[:, 0])])


def test_sanitize_bonds_selection(geometry):
Expand Down
Loading