Fix NodeService::setIdentity(..).

[aarlt]

I think there was a typo here.

[joseph-henry]

I don't think this is a typo. Is something not working for you? We perform this check so that one doesn't accidentally write too much data into the internal string buffer.

[aarlt]

@joseph-henry I was not able to use this function. I created a new key pair with the lib, and the code always returned an error.

if (keypair == NULL || len < ZT_IDENTITY_STRING_BUFFER_LENGTH) {
   return ZTS_ERR_ARG;
}

I understood it like this:

• if the pointer to key pair points to nullptr, return an error, or
• if the length of the key is less than provided by the buffer.

But why should the second part be an error? Isn't it only an error, if the provided length is larger than the max. buffer size available? I think it's ok, if the length was smaller or equal than the maximal buffer length.

[aarlt]

I don't think this is a typo. Is something not working for you? We perform this check so that one doesn't accidentally write too much data into the internal string buffer.

But yeah! I was also really wondering, because that would mean that nobody ever used this function so far. But maybe I really missed something here.

[joseph-henry]

Heh. Checking test/selftest.c I have testing for zts_init_from_memory marked for "tomorrow" like 8 months ago. So you might be right about this. I'll test locally.

[aarlt]

Heh. Checking test/selftest.c I have testing for zts_init_from_memory marked for "tomorrow" like 8 months ago. So you might be right about this. I'll test locally.

looks like nothing changed in test/selftest.c since many years.. it's somehow a bit scary that you only uncommented the return of the error - in June 2023...

[aarlt]

I hope that you simply just don't release your real tests.

[joseph-henry]

Sorry not sure why this got closed and never properly fixed. And also, yes it looks like that was commented out to get around an issue while developing Pylon but erroneously got included in a commit.

I've now included a check so that all buffers must be exactly 384 bytes in length and added some tests in selftest.c to verify this is checked.

Thanks for pointing this out and sorry it too so long to fix.