CMakeLists: avoid adding/compiling sources twice in static lib #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling as static library the "main" sources (
libztSrcGlob
) are added tozt_pic
and the static library itself.The static library on the other hand also includes
zt_pic
. That means the code is included twice and MSVC warns about it (LNK4006).This PR removes the second include/compilation.
When compiling with MSVC this PR removes 256 warnings.
Found in devilutionX (see also related discussion).
Example warnings: