Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node JS example #76

Merged
merged 7 commits into from
Sep 12, 2020
Merged

Add Node JS example #76

merged 7 commits into from
Sep 12, 2020

Conversation

heri16
Copy link

@heri16 heri16 commented Aug 7, 2020

Add example and binding for nodejs.

Behave the same as the built-in net.connect() or net.createConnection() API in nodejs.

Tested to work on node v12.18.0

See Issue #10

@joseph-henry
Copy link
Contributor

@heri16 Thank you for this. I'm only just now getting to it but before I start testing it is there anything I should wait for or be aware of?

@joseph-henry
Copy link
Contributor

@heri16 I've reviewed your PR and it appears to be quality work so I will merge it.

One minor licensing point however is that while example code/wrappers can be contributed as non-BSL (e.g. your use of MIT License), I will change the license field of package.json to BSL since it is referring to libzt which is Licensed under BSL.

If you would like to attach headers to your files stating that the contents themselves are licensed under MIT, that would be totally acceptable since you wrote it after all.

Thanks again for your contribution and let me know if you have any questions.

@joseph-henry joseph-henry merged commit d43b92f into zerotier:master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants